[libcamera-devel] [PATCH v2 0/5] Remove Raspberry Pi logging

David Plowman david.plowman at raspberrypi.com
Mon Jan 25 19:48:53 CET 2021


Hi again everyone

Version 2 of this set again makes no functional changes beyond debug
logging. There are the following differences compared to v1:

* I've removed some debug messages that were unnecessary (either just
  tracing statements or duplicates).

* A number of messages repeated the algorithm name which is
  unnecessary with libcamera logging.

* One or two that were actually warnings without using LOG(RPiXxx,
  Warning) have been amended.

* A bit more whitespace tidying.

I've actually folded the changes into the original commits, I think
it's easy enough to follow like this.

Most of Laurent's other suggestions I'd be fine with if we wanted to
pursue them (except the one about sharing frame counts between
algorithms - I'm actually really paranoid about that!).

Thanks!
David

David Plowman (5):
  ipa: raspberrypi: controller: Replace Raspberry Pi debug with
    libcamera debug
  ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera
    debug
  ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug
  ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug
  ipa: raspberrypi: Remove legacy Rasberry Pi logging

 src/ipa/raspberrypi/controller/algorithm.hpp  |  1 -
 src/ipa/raspberrypi/controller/controller.cpp | 19 ++--
 src/ipa/raspberrypi/controller/logging.hpp    | 30 ------
 src/ipa/raspberrypi/controller/rpi/alsc.cpp   | 66 +++++++------
 src/ipa/raspberrypi/controller/rpi/awb.cpp    | 97 ++++++++++---------
 .../controller/rpi/black_level.cpp            | 11 ++-
 src/ipa/raspberrypi/controller/rpi/ccm.cpp    | 26 +++--
 .../raspberrypi/controller/rpi/contrast.cpp   | 20 +++-
 src/ipa/raspberrypi/controller/rpi/dpc.cpp    |  8 +-
 src/ipa/raspberrypi/controller/rpi/geq.cpp    | 20 ++--
 src/ipa/raspberrypi/controller/rpi/lux.cpp    | 11 ++-
 src/ipa/raspberrypi/controller/rpi/noise.cpp  | 14 ++-
 src/ipa/raspberrypi/controller/rpi/sdn.cpp    | 21 ++--
 .../raspberrypi/controller/rpi/sharpen.cpp    | 11 ++-
 14 files changed, 192 insertions(+), 163 deletions(-)
 delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp

-- 
2.20.1



More information about the libcamera-devel mailing list