[libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise

Naushir Patuck naush at raspberrypi.com
Fri Jan 29 16:11:48 CET 2021


Hi,

Version 5 of this patch series addresses all the review comments in v4:
- Switch DenoiseMode to an enum class.
- Avoid double lookup in the DenoiseMode conversion table.
- Add controls::draft::NoiseReductionMode to the available controls handled by the IPA.

Regards,
Naush


Naushir Patuck (6):
  pipeline: raspberrypi: Refactor stream configuration routine
  pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused
  uapi: raspberrypi: Update the bcm2835-isp header definition
  ipa: raspberrypi: Rename SdnStatus to DenoiseStatus
  ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller
  ipa: raspberrypi: Handle control::NoiseReductionMode in the controller

 include/libcamera/ipa/raspberrypi.h           |  1 +
 include/linux/bcm2835-isp.h                   | 32 ++++++-
 .../controller/denoise_algorithm.hpp          | 23 +++++
 .../{sdn_status.h => denoise_status.h}        |  7 +-
 src/ipa/raspberrypi/controller/rpi/sdn.cpp    | 17 ++--
 src/ipa/raspberrypi/controller/rpi/sdn.hpp    |  5 +-
 src/ipa/raspberrypi/raspberrypi.cpp           | 59 +++++++++++--
 .../pipeline/raspberrypi/raspberrypi.cpp      | 86 ++++++++++---------
 8 files changed, 174 insertions(+), 56 deletions(-)
 create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp
 rename src/ipa/raspberrypi/controller/{sdn_status.h => denoise_status.h} (62%)

-- 
2.25.1



More information about the libcamera-devel mailing list