[libcamera-devel] [PATCH 2/2] android: Disable copy and move for CameraDevice

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jul 5 01:36:20 CEST 2021


Instances of the CameraDevice class should never be copied or moved, as
they represent resources, Disable copying and moving for the class.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/android/camera_device.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/android/camera_device.h b/src/android/camera_device.h
index 3361918d4484..d085a27f296b 100644
--- a/src/android/camera_device.h
+++ b/src/android/camera_device.h
@@ -14,6 +14,7 @@
 
 #include <hardware/camera3.h>
 
+#include <libcamera/base/class.h>
 #include <libcamera/base/log.h>
 #include <libcamera/base/message.h>
 #include <libcamera/base/thread.h>
@@ -66,6 +67,8 @@ protected:
 	std::string logPrefix() const override;
 
 private:
+	LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraDevice)
+
 	CameraDevice(unsigned int id, std::shared_ptr<libcamera::Camera> camera);
 
 	struct Camera3RequestDescriptor {
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list