[libcamera-devel] [PATCH] ipa: libipa: Fix ov5670 analogue gain parameters

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Mon Jul 5 18:01:20 CEST 2021


Based on datasheet, the gain multiplier is 128 and not 256 (the
fraction bits are the 7 lower bits). Fix it.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
Change-Id: I87e4b078f65c68da005a3ad4f1216256b8487df7
---
 src/ipa/libipa/camera_sensor_helper.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index 23335ed6..cd0a19bb 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -294,7 +294,7 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper
 public:
 	CameraSensorHelperOv5670()
 	{
-		analogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 256 };
+		analogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };
 	}
 };
 REGISTER_CAMERA_SENSOR_HELPER("ov5670", CameraSensorHelperOv5670)
-- 
2.30.2



More information about the libcamera-devel mailing list