[libcamera-devel] [PATCH 22/30] cam: Make CamApp::cameraName() static

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Jul 7 04:19:33 CEST 2021


The CamApp::cameraName() doesn't need to access any member of the CamApp
class. Make is static. While at is, drop an unneded const from the
return value.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/cam/main.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/cam/main.cpp b/src/cam/main.cpp
index 19ed9837cf4f..03e62f305f24 100644
--- a/src/cam/main.cpp
+++ b/src/cam/main.cpp
@@ -44,7 +44,7 @@ private:
 	int infoConfiguration();
 	int run();
 
-	std::string const cameraName(const Camera *camera);
+	static std::string cameraName(const Camera *camera);
 
 	static CamApp *app_;
 	OptionsParser::Options options_;
@@ -319,7 +319,7 @@ int CamApp::run()
 	return 0;
 }
 
-std::string const CamApp::cameraName(const Camera *camera)
+std::string CamApp::cameraName(const Camera *camera)
 {
 	const ControlList &props = camera->properties();
 	bool addModel = true;
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list