[libcamera-devel] RPi algorithm optimal call order

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Thu Jul 8 11:14:20 CEST 2021


Hi David, Naushir,

I want to generalize the algorithm concept you are using in RPi to IPU3
and then to all IPAs.

I want to use a Factory design pattern, like for PipelineHandler or
CameraSensorHelper, but a question appears: is there an order to respect
when calling the algorithms ?

Reading the RPi implementation, I can't find a very strong need for
algorithms to be called in a specific order. In the case of AWB / AGC if
you don't have updated values for awb gains, you just use the default
ones or latest frame ones. So we are one frame off.

The order is implicitly defined by the order in the json file:
Black level -> DPC -> Lux -> Noise -> geq -> sdn -> awb -> agc -> alsc
-> contrast -> ccm -> sharpen

But the apply() of each calculated parameter only occurs at the end of
the sharpen call, so the influence is only on next frame.

Am I missing something here, is there a strong need for ordering or is
it marginal ?

Thanks for your advices ;-).

JM


More information about the libcamera-devel mailing list