[libcamera-devel] [PATCH v5 7/8] ipa: raspberrypi: Increase the default max frame duration to 250s

[Kieran Bingham]

Hi Naush,

On 09/07/2021 10:56, Naushir Patuck wrote:
> With the recent change to allow long exposures on the imx477, the existing 100s
> limit was not adequate.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman at raspberrypi.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index db103a885b7a..8fb98a49da63 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -62,7 +62,7 @@ using utils::Duration;
>  constexpr double DefaultAnalogueGain = 1.0;
>  constexpr Duration DefaultExposureTime = 20.0ms;
>  constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;
> -constexpr Duration defaultMaxFrameDuration = 100.0s;
> +constexpr Duration defaultMaxFrameDuration = 250.0s;

I really love the Duration post-fixes. Makes this so clear and readable.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

>  
>  /*
>   * Determine the minimum allowable inter-frame duration to run the controller
>