[libcamera-devel] [RFC PATCH v3 12/16] pipeline: ipu3: Set MaxLatency ControlInfo

[Laurent Pinchart]

Hi Jacopo,

On Mon, Jul 05, 2021 at 05:56:11PM +0200, Jacopo Mondi wrote:
> On Fri, Jul 02, 2021 at 07:37:56PM +0900, Paul Elder wrote:
> > We want the IPU3 IPA to support setting MaxLatency, so initialize the
> > MaxLatency ControlInfo in the IPU3 pipeline handler.
> >
> > Bug: https://bugs.libcamera.org/show_bug.cgi?id=50
> > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> I wish... isn't it a bie early to claim so ? :)

Let's say that the patch itself is fine, but more changes are needed if
we don't want to lie :-)

Do you think we should delay merging this ?

> > ---
> > No change in v3
> > ---
> >  src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> > index 76c3bb3d..d3dafd98 100644
> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> > @@ -49,6 +49,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;
> >  static constexpr Size IPU3ViewfinderSize(1280, 720);
> >
> >  static const ControlInfoMap::Map IPU3Controls = {
> > +	{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },
> >  	{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },
> >  };
> >

-- 
Regards,

Laurent Pinchart