[libcamera-devel] [PATCH 1/3] libcamera: ipa_manager: Fix IPA module min/max version check

[Kieran Bingham]

Hi Laurent,

On 12/07/2021 00:15, Laurent Pinchart wrote:
> The IPAManager::createIPA() function has its minVersion and maxVersion
> parameters inverted. This doesn't cause any issue at the moment as both
> the minimum and maximum version are set to 1 by all callers, but it's
> still a bug. Fix it.


Certainly seems more logical to have min,max, rather than max,min!

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  include/libcamera/internal/ipa_manager.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h
> index 34224e330da7..42201839901b 100644
> --- a/include/libcamera/internal/ipa_manager.h
> +++ b/include/libcamera/internal/ipa_manager.h
> @@ -31,8 +31,8 @@ public:
>  
>  	template<typename T>
>  	static std::unique_ptr<T> createIPA(PipelineHandler *pipe,
> -					    uint32_t maxVersion,
> -					    uint32_t minVersion)
> +					    uint32_t minVersion,
> +					    uint32_t maxVersion)
>  	{
>  		IPAModule *m = nullptr;
>  
>