[libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused MetadataPtr

[Laurent Pinchart]

Hi Jean-Michel,

Thank you for the patch.

On Wed, Jul 14, 2021 at 11:06:59AM +0200, Jean-Michel Hautbois wrote:
> The Metadata class defines a shared_ptr named MetadataPtr.  It is not
> used anywhere in the source code, so remove it.
> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>

Avoiding new std::shared_ptr<> users is also a good idea.

You can now drop inclusion of <memory>. With this,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/controller/metadata.hpp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/controller/metadata.hpp b/src/ipa/raspberrypi/controller/metadata.hpp
> index fd6aac88..4b2b4ca3 100644
> --- a/src/ipa/raspberrypi/controller/metadata.hpp
> +++ b/src/ipa/raspberrypi/controller/metadata.hpp
> @@ -108,6 +108,4 @@ private:
>  	std::map<std::string, std::any> data_;
>  };
>  
> -typedef std::shared_ptr<Metadata> MetadataPtr;
> -
>  } // namespace RPiController

-- 
Regards,

Laurent Pinchart