[libcamera-devel] [PATCH] cam: Initialize CamApp::loopUsers_

Umang Jain umang.jain at ideasonboard.com
Fri Jul 23 16:16:08 CEST 2021


Hi Laurent,

Thanks for the patch.

On 7/23/21 9:34 AM, Laurent Pinchart wrote:
> The CamApp loopUsers_ member variable isn't initialized, which results
> in random execution of the event loop. Fix it.
>
> Fixes: caa6ffacb2fc ("cam: Reorganize run() function and merge the two event loops")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
Tested-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>   src/cam/main.cpp | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/cam/main.cpp b/src/cam/main.cpp
> index f9a90672a474..34cbc3229563 100644
> --- a/src/cam/main.cpp
> +++ b/src/cam/main.cpp
> @@ -56,6 +56,7 @@ private:
>   CamApp *CamApp::app_ = nullptr;
>   
>   CamApp::CamApp()
> +	: loopUsers_(0)
>   {
>   	CamApp::app_ = this;
>   }


More information about the libcamera-devel mailing list