[libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor properties.

Umang Jain umang.jain at ideasonboard.com
Sat Jul 24 07:05:28 CEST 2021


Hi Daniel,

Thanks for the patch.

On 7/23/21 2:06 AM, Daniel Scally wrote:
> Add camera sensor properties for the OV8865 sensor. This is the world
> facing camera on most MS Surface platforms.
>
> Signed-off-by: Daniel Scally <djrscally at gmail.com>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>   src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 7d8ba9e9..e1b6416b 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -102,6 +102,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>   				 */
>   			},
>   		} },
> +		{ "ov8865", {
> +			.unitCellSize = { 1400, 1400 },
> +			.testPatternModes = {
> +				{ 0, controls::draft::TestPatternModeOff },
> +				{ 2, controls::draft::TestPatternModeColorBars },
> +				/*
> +				 * No corresponding test pattern mode for:
> +				 * 1: "Random data"
> +				 * 3: "Colour Bars with Rolling Bar"
> +				 * 4: "Color squares"
> +				 * 5: "Color squares with rolling bar"
> +				 */
> +			},
> +		} },
>   	};
>   
>   	const auto it = sensorProps.find(sensor);


More information about the libcamera-devel mailing list