[libcamera-devel] [PATCH 1/2] libipa: Add CameraSensorHelper for ov8865

[Umang Jain]

Hi Daniel,

Thanks for the patch.

On 7/23/21 2:06 AM, Daniel Scally wrote:
> Add a CameraSensorHelperOv8865 class. The gain coefficients are gleaned
> from the datasheet; the lowest 7 bits are reported there as fractional
> bits, so real gain is val/128.
>
> Signed-off-by: Daniel Scally <djrscally at gmail.com>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>   src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index 709835a8..e72167ec 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -325,6 +325,16 @@ public:
>   };
>   REGISTER_CAMERA_SENSOR_HELPER("ov13858", CameraSensorHelperOv13858)
>   
> +class CameraSensorHelperOv8865 : public CameraSensorHelper
> +{
> +public:
> +	CameraSensorHelperOv8865()
> +	{
> +		analogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };
> +	}
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("ov8865", CameraSensorHelperOv8865)
> +
>   #endif /* __DOXYGEN__ */
>   
>   } /* namespace ipa */