[libcamera-devel] [PATCH] android: nautilus: Add camera HAL configuration

[Laurent Pinchart]

Hi Umang,

Thank you for the patch.

On Sat, Jul 24, 2021 at 02:51:47PM +0530, Umang Jain wrote:
> Nautilus has two in-built cameras, one UVC and one attached to IPU3.
> However, libcamera assumes all UVC cameras as 'external' [1] hence,
> mark the location of UVC camera in HAL configuration as 'external' too.

That's not right thought, this particular camera isn't external. What
would it take to fix it ?

> [1] 76809320bb1a ("libcamera: pipeline: uvcvideo: Treat all UVC cameras as external")
> 
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>  src/android/data/nautilus/camera_hal.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 src/android/data/nautilus/camera_hal.yaml
> 
> diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml
> new file mode 100644
> index 00000000..f2d31e1c
> --- /dev/null
> +++ b/src/android/data/nautilus/camera_hal.yaml
> @@ -0,0 +1,8 @@
> +cameras:
> +  "\\_SB_.PCI0.I2C2.CAM0":
> +    location: back
> +    rotation: 0
> +
> +  "\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647":
> +    location: external
> +    rotation: 0

-- 
Regards,

Laurent Pinchart