[libcamera-devel] [PATCH] libcamera: CameraSensorProperties: Sort entries

[paul.elder at ideasonboard.com]

Hi Laurent,

On Sun, Jul 25, 2021 at 02:48:55AM +0300, Laurent Pinchart wrote:
> Keep entries sorted by sensor name to ensure the file stays readable.

This was bugging me for a while :)

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  src/libcamera/camera_sensor_properties.cpp | 28 +++++++++++-----------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index c6f383e0ac03..4ee45e72e8a8 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -72,24 +72,17 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  				{ 4, controls::draft::TestPatternModePn9 },
>  			},
>  		} },
> -		{ "ov5670", {
> -			.unitCellSize = { 1120, 1120 },
> -			.testPatternModes = {
> -				{ 0, controls::draft::TestPatternModeOff },
> -				{ 1, controls::draft::TestPatternModeColorBars },
> -			},
> -		} },
> -		{ "ov13858", {
> -			.unitCellSize = { 1120, 1120 },
> -			.testPatternModes =  {
> -				{ 0, controls::draft::TestPatternModeOff },
> -				{ 1, controls::draft::TestPatternModeColorBars },
> -			},
> -		} },
>  		{ "ov5647", {
>  			.unitCellSize = { 1400, 1400 },
>  			.testPatternModes = {},
>  		} },
> +		{ "ov5670", {
> +			.unitCellSize = { 1120, 1120 },
> +			.testPatternModes = {
> +				{ 0, controls::draft::TestPatternModeOff },
> +				{ 1, controls::draft::TestPatternModeColorBars },
> +			},
> +		} },
>  		{ "ov5693", {
>  			.unitCellSize = { 1400, 1400 },
>  			.testPatternModes = {
> @@ -116,6 +109,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  				 */
>  			},
>  		} },
> +		{ "ov13858", {
> +			.unitCellSize = { 1120, 1120 },
> +			.testPatternModes =  {
> +				{ 0, controls::draft::TestPatternModeOff },
> +				{ 1, controls::draft::TestPatternModeColorBars },
> +			},
> +		} },
>  	};
>  
>  	const auto it = sensorProps.find(sensor);
> -- 
> Regards,
> 
> Laurent Pinchart
>