[libcamera-devel] [PATCH v1] gstreamer: Update format specifier in Request Pad template

[Laurent Pinchart]

Hi Vedant,

Thank you for the patch.

On Wed, Jul 28, 2021 at 01:17:24AM +0530, Vedant Paranjape wrote:
> Change format specifier %s to %u in request pad template

This is pretty obvious from the patch itself. What isn't obvious,
however, is why, and that's what a commit message body should focus on.
Every commit message needs to answer the "why" question, may explain
"how" when not immediately visible, and could also explain "what" if
it's not obvious.

> Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> ---
>  src/gstreamer/gstlibcamerasrc.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
> index bb8ea07a..553fad02 100644
> --- a/src/gstreamer/gstlibcamerasrc.cpp
> +++ b/src/gstreamer/gstlibcamerasrc.cpp
> @@ -149,7 +149,7 @@ GstStaticPadTemplate src_template = {
>  
>  /* More pads can be requested in state < PAUSED */
>  GstStaticPadTemplate request_src_template = {
> -	"src_%s", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS
> +	"src_%u", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS
>  };
>  
>  void

-- 
Regards,

Laurent Pinchart