[libcamera-devel] [PATCH v3 2/4] android: Disallow external location in HAL config

Umang Jain umang.jain at ideasonboard.com
Fri Jul 30 13:01:52 CEST 2021


Error out on any camera's location if set to "external",
in the HAL configuration file. The HAL configuration file
is only meant for the integrated cameras present on the system.

Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
---
 src/android/camera_hal_config.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp
index 833cf4ba..7126aba4 100644
--- a/src/android/camera_hal_config.cpp
+++ b/src/android/camera_hal_config.cpp
@@ -127,8 +127,6 @@ int CameraHalConfig::Private::parseCameraLocation(CameraConfigData *cameraConfig
 		cameraConfigData->facing = CAMERA_FACING_FRONT;
 	else if (location == "back")
 		cameraConfigData->facing = CAMERA_FACING_BACK;
-	else if (location == "external")
-		cameraConfigData->facing = CAMERA_FACING_EXTERNAL;
 	else
 		return -EINVAL;
 
-- 
2.31.0



More information about the libcamera-devel mailing list