[libcamera-devel] [PATCH 1/2] android: Make FRAME_DURATION key available in static metadata

[Umang Jain]

Hi Laurent,

On 6/2/21 6:43 AM, Laurent Pinchart wrote:
> Hi Umang,
>
> Thank you for the patch.
>
> On Tue, Jun 01, 2021 at 04:54:55PM +0530, Umang Jain wrote:
>> Report ANDROID_SENSOR_FRAME_DURATION as an available key for CTS to
>> read out the value of frame duration we set in CameraDevice::getResultMetadata().
>> Failing to do so might fail the CTS test:
>>   - android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl
>>
>> Fixes: 3beb1accac1d ("android: camera_device: Fix sensor frame duration")
>> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> Looks good to me.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> Do I understand that this can be applied separately from 2/2 ?
As far as I understand, yes it can be applied.
>
>> ---
>>   src/android/camera_device.cpp | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
>> index fddc07ff..fe332ec3 100644
>> --- a/src/android/camera_device.cpp
>> +++ b/src/android/camera_device.cpp
>> @@ -1422,6 +1422,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()
>>   		ANDROID_REQUEST_PIPELINE_DEPTH,
>>   		ANDROID_SCALER_CROP_REGION,
>>   		ANDROID_SENSOR_EXPOSURE_TIME,
>> +		ANDROID_SENSOR_FRAME_DURATION,
>>   		ANDROID_SENSOR_ROLLING_SHUTTER_SKEW,
>>   		ANDROID_SENSOR_TEST_PATTERN_MODE,
>>   		ANDROID_SENSOR_TIMESTAMP,