[libcamera-devel] [PATCH] src/qcam/meson.build: add libatomic dependency

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Jun 2 23:25:10 CEST 2021


Hi Fabrice,

Thank you for the patch.

On Wed, Jun 02, 2021 at 10:56:49PM +0200, Fabrice Fontaine wrote:
> Add libatomic dependency due to std::shared_ptr which is used by qcam
> since its addition in commit 97e8b3a2eb321884fe1e15fb584f41a38cc33d51:
> https://en.cppreference.com/w/cpp/memory/shared_ptr.
> 
> This will avoid the following build failure:
> 
> /srv/storage/autobuild/run/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/9.3.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: src/qcam/qcam.p/main_window.cpp.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d0726b2253f1f3d006e057f3b32c646c4b9b5f7a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

and applied with the subject line reworded to

	qcam: Add libatomic dependency

to match the usual format.

> ---
>  src/qcam/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/qcam/meson.build b/src/qcam/meson.build
> index acde7682..fad4cc95 100644
> --- a/src/qcam/meson.build
> +++ b/src/qcam/meson.build
> @@ -34,6 +34,7 @@ qcam_resources = files([
>  ])
>  
>  qcam_deps = [
> +    libatomic,
>      libcamera_dep,
>      qt5_dep,
>  ]

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list