[libcamera-devel] [PATCH 0/4] IPAIPU3 drive-by improvements

[paul.elder at ideasonboard.com]

Hi Laurent,

On Tue, Jun 08, 2021 at 01:32:10AM +0300, Laurent Pinchart wrote:
> Hi Paul,
> 
> On Thu, Jun 03, 2021 at 03:39:51PM +0900, paul.elder at ideasonboard.com wrote:
> > On Wed, Jun 02, 2021 at 03:53:22PM +0530, Umang Jain wrote:
> > > Here are few patches that might be considered as enhancements.
> > > 
> > > The patches journey was led by the reviews from
> > > "[PATCH 0/2] frame-durations CTS fixups", however this doesn't yet
> > > fixup the frame-duration value for CTS, on my `nautilus` platform. But I
> > > assume, it shall still relevant CTS tests on `soraka` (Can anyone
> > > please help me confirm)?
> > 
> > They all pass CTS on soraka \o/
> 
> Just to make sure, does this only mean no regression, or do we have
> improvements ?

No regression.


Paul

> 
> > For all (although I guess 1/4 has already been merged),
> > 
> > Tested-by: Paul Elder <paul.elder at ideasonboard.com>
> > 
> > > 
> > > Patch 1/4: Addressed minor comments from original series
> > > Patch 2/4: Replaces hard-coded line duration(enhancement) using real
> > >            values
> > > 
> > > Patch 3/4: Caching IPACameraSensorInfo
> > > Patch 4/4: Replace frame-duration with something better?!
> > > 
> > > Umang Jain (4):
> > >   android: Make FRAME_DURATION result key available in static metadata
> > >   ipa: ipu3: Calculate line duration from IPACameraSensorInfo
> > >   ipa: ipu3: Copy IPACameraSensorInfo for future usage
> > >   ipa: ipu3: Calculate frame duration from minimum VBLANK value
> > > 
> > >  src/android/camera_device.cpp |  1 +
> > >  src/ipa/ipu3/ipu3.cpp         | 22 ++++++++++++++++++----
> > >  src/ipa/ipu3/ipu3_agc.cpp     | 22 +++++++++++-----------
> > >  src/ipa/ipu3/ipu3_agc.h       |  7 ++++++-
> > >  4 files changed, 36 insertions(+), 16 deletions(-)