[libcamera-devel] [PATCH v2 2/3] ipa: ipu3: Copy IPACameraSensorInfo for future usage

Umang Jain umang.jain at ideasonboard.com
Tue Jun 8 09:42:24 CEST 2021


IPACameraSensorInfo members will be needed at various places in the
IPAIPU3 class, in subsequent commits. Hence, it seems trivial to copy
this structure for wider availability throughout the class.

This commit does not introduce any functional changes.

Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
Tested-by: Paul Elder <paul.elder at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/ipa/ipu3/ipu3.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index 2496b0a0..97ddb863 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -63,6 +63,8 @@ private:
 
 	ControlInfoMap ctrls_;
 
+	IPACameraSensorInfo sensorInfo_;
+
 	/* Camera sensor controls. */
 	uint32_t exposure_;
 	uint32_t minExposure_;
@@ -144,6 +146,8 @@ void IPAIPU3::configure(const IPAConfigInfo &configInfo)
 	if (configInfo.entityControls.empty())
 		return;
 
+	sensorInfo_ = configInfo.sensorInfo;
+
 	ctrls_ = configInfo.entityControls.at(0);
 
 	const auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);
@@ -174,7 +178,7 @@ void IPAIPU3::configure(const IPAConfigInfo &configInfo)
 	awbAlgo_->initialise(params_, configInfo.bdsOutputSize, bdsGrid_);
 
 	agcAlgo_ = std::make_unique<IPU3Agc>();
-	agcAlgo_->initialise(bdsGrid_, configInfo.sensorInfo);
+	agcAlgo_->initialise(bdsGrid_, sensorInfo_);
 }
 
 void IPAIPU3::mapBuffers(const std::vector<IPABuffer> &buffers)
-- 
2.31.1



More information about the libcamera-devel mailing list