[libcamera-devel] [RFC PATCH] android: camera_device: Drop HAL_PIXEL_FORMAT_RAW_OPAQUE support

[Jacopo Mondi]

Hello,

On Tue, Jun 15, 2021 at 01:44:12AM +0300, Laurent Pinchart wrote:
> Hi Hiro,
>
> Thank you for the patch.
>
> On Mon, Jun 14, 2021 at 07:45:53PM +0900, Hirokazu Honda wrote:
> > HAL_PIXEL_FORMAT_RAW_OPAQUE is requested only for
> > Zero-Shutter-Lag (ZSL). ZSL requires RAW and YUV reprocessing.
> > Since either of them is not supported by libcamera, supporting
> > RAW_OPAQUE format doesn't make sense. Drop the format from the
> > supported format list.
> >
> > Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
>
> This looks sensible to me. Given that the formats below are specific to
> the IPU3, the code would need to be reworked when we'll implement ZSL
> support anyway.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> I'll wait for a second tag before merging.

Have mine
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Those are IPU3 specific formats, not sure they belong here

>
> > ---
> >  src/android/camera_device.cpp | 11 -----------
> >  1 file changed, 11 deletions(-)
> >
> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> > index fe332ec3..14022aed 100644
> > --- a/src/android/camera_device.cpp
> > +++ b/src/android/camera_device.cpp
> > @@ -120,17 +120,6 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {
> >  			false,
> >  			"RAW16"
> >  		}
> > -	}, {
> > -		HAL_PIXEL_FORMAT_RAW_OPAQUE, {
> > -			{
> > -				formats::SBGGR10_IPU3,
> > -				formats::SGBRG10_IPU3,
> > -				formats::SGRBG10_IPU3,
> > -				formats::SRGGB10_IPU3
> > -			},
> > -			false,
> > -			"RAW_OPAQUE"
> > -		}
> >  	},
> >  };
> >
>
> --
> Regards,
>
> Laurent Pinchart