[libcamera-devel] [PATCH 4/4] ipa: raspberrypi: Make variable names consistent

[David Plowman]

Hi Naush

Thanks for this patch!

On Mon, 14 Jun 2021 at 11:00, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> s/DefaultAnalogueGain/defaultAnalogueGain/
> s/DefaultExposureTime/defaultExposureTime/
>
> Change these for consistency with the other static const variables.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>

Thanks
David

> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 8a8e9c0a52ab..e15d49e49645 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -58,8 +58,8 @@ using namespace std::literals::chrono_literals;
>  using utils::Duration;
>
>  /* Configure the sensor with these values initially. */
> -constexpr double DefaultAnalogueGain = 1.0;
> -constexpr Duration DefaultExposureTime = 20.0ms;
> +constexpr double defaultAnalogueGain = 1.0;
> +constexpr Duration defaultExposureTime = 20.0ms;
>  constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;
>  constexpr Duration defaultMaxFrameDuration = 250.0s;
>
> @@ -389,8 +389,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,
>                 /* Supply initial values for gain and exposure. */
>                 ControlList ctrls(sensorCtrls_);
>                 AgcStatus agcStatus;
> -               agcStatus.shutter_time = DefaultExposureTime;
> -               agcStatus.analogue_gain = DefaultAnalogueGain;
> +               agcStatus.shutter_time = defaultExposureTime;
> +               agcStatus.analogue_gain = defaultAnalogueGain;
>                 applyAGC(&agcStatus, ctrls);
>
>                 ASSERT(controls);
> --
> 2.25.1
>