[libcamera-devel] [PATCH 0/3] Raspberry Pi: Metadata parsing improvements (II)

Naushir Patuck naush at raspberrypi.com
Tue Jun 15 16:42:08 CEST 2021


Hi,

This is a new patch series that replaces the old one at:
https://patchwork.libcamera.org/project/libcamera/list/?series=2128

This series is rebased on top of the 4 patches merged from the earlier series,
along with the following changes:

- Patch 1/3 uses the constructor initialiser list to return the pointer to the
parser to the base class (as we did previously).
- I have separated out the buffer overrun test change into its own patch (2/3).
- Reworked patch 3/3 to add a more explicit distinction in the parser between
parsing for register offsets and using register values to obtain exposure/gain
values.  This change is based on Laurent's feedback on the earlier series, and
I am happy to take suggestions on how this could be improved.

Thanks,
Naush

Naushir Patuck (3):
  ipa: raspberrypi: Embed the metadata parser in the sensor CamHelper
    classes
  ipa: raspberrypi: Fix possible buffer overrun in metadata parsing
  ipa: raspberrypi: Generalise the SMIA metadata parser

 src/ipa/raspberrypi/cam_helper.cpp        |  36 ++++---
 src/ipa/raspberrypi/cam_helper.hpp        |   2 +
 src/ipa/raspberrypi/cam_helper_imx219.cpp | 118 +++++---------------
 src/ipa/raspberrypi/cam_helper_imx477.cpp | 124 +++++-----------------
 src/ipa/raspberrypi/md_parser.hpp         |  42 +++++---
 src/ipa/raspberrypi/md_parser_smia.cpp    |  70 +++++++++---
 6 files changed, 152 insertions(+), 240 deletions(-)

-- 
2.25.1



More information about the libcamera-devel mailing list