[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report error when failing to configure

[Hirokazu Honda]

Hi Kieran, thank you for the patch.

On Wed, Jun 16, 2021 at 6:56 PM Kieran Bingham <
kieran.bingham at ideasonboard.com> wrote:

> If the IPA fails to configure, this can now be caught by the pipeline
> handler
> but the cause may not be clear.
>
> If the IPA is isolated, then reports from that IPA will not be visible
> in the libcamera logs directly.
>
> Print the return error value to help identify any issue that has arisen.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>


> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp
> b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 35f1e977ab19..113e70a5e692 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -644,7 +644,8 @@ int PipelineHandlerIPU3::configure(Camera *camera,
> CameraConfiguration *c)
>
>         ret = data->ipa_->configure(configInfo);
>         if (ret) {
> -               LOG(IPU3, Error) << "Failed to configure IPA";
> +               LOG(IPU3, Error) << "Failed to configure IPA: "
> +                                << strerror(-ret);
>                 return ret;
>         }
>
> --
> 2.30.2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210616/5f7eca5a/attachment.htm>