[libcamera-devel] [PATCH v3] android: jpeg: get ISO from SENSOR_SENSITIVITY

[paul.elder at ideasonboard.com]

Hi Hiro,

Thank you for the review.

On Thu, Jun 17, 2021 at 02:31:11PM +0900, Hirokazu Honda wrote:
> HI Paul, thank you for the patch.
> 
> On Thu, Jun 17, 2021 at 1:58 PM Paul Elder <paul.elder at ideasonboard.com> wrote:
> 
>     The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY. Set
>     it.
> 
>     Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
>     Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
>     ---
>     This on its own doesn't fix any CTS tests, but it prevents a test
>     failure later on when we add the proper static metadata for the FULL
>     hardware level.
>     ---
>      src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-
>      1 file changed, 4 insertions(+), 1 deletion(-)
> 
>     diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/
>     post_processor_jpeg.cpp
>     index 058ccc99..921ac823 100644
>     --- a/src/android/jpeg/post_processor_jpeg.cpp
>     +++ b/src/android/jpeg/post_processor_jpeg.cpp
>     @@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const FrameBuffer &
>     source,
>             ret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &entry);
>             if (ret)
>                     exif.setAperture(*entry.data.f);
>     -       exif.setISO(100);
>     +
>     +       ret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY, &entry);
>     +       exif.setISO(ret ? *entry.data.i32 : 100);
> 
> 
> Noob: where does 100 come from?

It was an arbitrary number that passed CTS LIMITED :D


Paul

> 
> Reviewed-by: Hirokazu Honda <hiroh at chromium.org> 
> 
>     +
>             exif.setFlash(Exif::Flash::FlashNotPresent);
>             exif.setWhiteBalance(Exif::WhiteBalance::Auto);
> 
>     --
>     2.27.0
> 
>