[libcamera-devel] [PATCH v3 0/3] Support monochrome raw sensors

[David Plowman]

Hi again

Here's a v3 set which addresses Kieran's comments, so thanks for
those! Otherwise everything is functionally the same as before.

To answer Kieran's other questions:

* Yes, a monochrome raw sensor is very different to a monochrome
  non-raw sensor! No black levels, vignetting to worry about on those,
  among other things.

* On the question of warning about missing AWB results only for
  monochrome sensors. Yes, that's a reasonable thought, though at the
  moment I don't think the IPA side of the world even knows if a
  sensor is monochrome. We'd have to pass that somehow, maybe in the
  IPACameraSesnsorInfo? That's perhaps a slightly longer discussion,
  I'm not entirely sure I want to open that right now...

* We need to be very nice to Dave, but then the plan would be to start
  upstreaming new drivers, as we've been doing previously. There are a
  couple more I'd like to get going too. Some of them would need a
  "Y12P" format, which seems to be missing from the kernel, currently.

* The tuning I've given for the OV9281 is for an Innomaker module, or
  maybe not, I'm not sure what it is. But it actually makes
  surprisingly little difference as there is no colour shading, AWB or
  colour matrices to worry about.

Thanks
David


David Plowman (3):
  libcamera: Add support for monochrome sensors
  libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results
  libcamera: ipa: raspberrypi: Add support for ov9281 sensor

 include/libcamera/internal/bayer_format.h   |  3 +-
 src/ipa/raspberrypi/cam_helper_mov9281.cpp  | 65 +++++++++++++++
 src/ipa/raspberrypi/controller/rpi/agc.cpp  |  2 +-
 src/ipa/raspberrypi/controller/rpi/alsc.cpp |  4 +-
 src/ipa/raspberrypi/data/meson.build        |  1 +
 src/ipa/raspberrypi/data/mov9281.json       | 92 +++++++++++++++++++++
 src/ipa/raspberrypi/meson.build             |  1 +
 src/libcamera/bayer_format.cpp              | 14 +++-
 src/libcamera/camera_sensor.cpp             |  3 +
 src/libcamera/property_ids.yaml             |  4 +
 10 files changed, 183 insertions(+), 6 deletions(-)
 create mode 100644 src/ipa/raspberrypi/cam_helper_mov9281.cpp
 create mode 100644 src/ipa/raspberrypi/data/mov9281.json

-- 
2.20.1