[libcamera-devel] [PATCH v1] libcamera: Add OV5647 sensor properties

[Laurent Pinchart]

Hi Vedant,

Thank you for the patch.

On Mon, Jun 21, 2021 at 07:04:49PM +0530, Vedant Paranjape wrote:
> Brief specifications available at
> https://cdn.sparkfun.com/datasheets/Dev/RaspberryPi/ov5647_full.pdf
> 
> Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> ---
>  src/libcamera/camera_sensor_properties.cpp | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index f660743a..43030e8b 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -81,6 +81,11 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  				{ 1, controls::draft::TestPatternModeColorBars },
>  			},
>  		} },
> +		{ "ov5647", {
> +			.unitCellSize = { 1400, 1400 },
> +			/* \todo fill test pattern modes for ov5647. */
> +			.testPatternModes = {},

How about filling them ? :-)

> +		} },
>  		{ "ov5693", {
>  			.unitCellSize = { 1400, 1400 },
>  			.testPatternModes = {

-- 
Regards,

Laurent Pinchart