[libcamera-devel] [RFC 1/1] android: Introduce CameraCapabilties class

[Laurent Pinchart]

Hi Jacopo,

On Mon, Jun 21, 2021 at 04:13:08PM +0200, Jacopo Mondi wrote:
> On Mon, Jun 21, 2021 at 05:06:38PM +0300, Laurent Pinchart wrote:
> > On Mon, Jun 21, 2021 at 03:53:45PM +0200, Jacopo Mondi wrote:
> 
> [big snip]
> 
> > > > >  /*
> > > > >   * \struct Camera3StreamConfig
> > > > >   * \brief Data to store StreamConfiguration associated with camera3_stream(s)
> > > > > @@ -512,242 +420,7 @@ int CameraDevice::initialize(const CameraConfigData *cameraConfigData)
> > > > >  		orientation_ = 0;
> > > > >  	}
> > > >
> > > > Shouldn't the code above be moved too ?
> > >
> > > It seems to me it deals with run time stream configuration, not to
> > > building the static list of available camera streams like the part I
> > > moved, doesn't it ?
> >
> > I meant the part related to orientation and location, isn't that static
> > ?
> 
> Ah sorry, didn't get it.
> I considered that, but that would have required moving the
> configuration file parsing to the capabilities class, and what's will
> be in the configuration file is still little bit still in flux
> 
> Also, the CameraDevice::initialize() would then be just a call to
> capabilties_.initialize().
> 
> What do you think ?

Whatever you think is best. This is a good first step in any case, and
I'm sure we'll continue refactoring the code.

-- 
Regards,

Laurent Pinchart