[libcamera-devel] [PATCH 1/2] android: Sort source files alphabetically

[Laurent Pinchart]

On Tue, Jun 22, 2021 at 09:29:23AM +0900, Hirokazu Honda wrote:
> On Tue, Jun 22, 2021 at 12:29 AM Jacopo Mondi <jacopo at jmondi.org> wrote:
> 
> > Sort the list of the Android HAL source file alphabetically.
> >
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> 
> I expect this is detected by the style check script, isn't it?

This would be nice, but checkstyle.py doesn't have support for this yet,
and it's a rabbit hole I'm not keen on exploring at this moment :-)

> Reviewed-by: Hirokazu Honda <hiroh at chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> > ---
> >  src/android/meson.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/android/meson.build b/src/android/meson.build
> > index 3893e5b5b832..f27fd5316705 100644
> > --- a/src/android/meson.build
> > +++ b/src/android/meson.build
> > @@ -44,9 +44,9 @@ subdir('cros')
> >
> >  android_hal_sources = files([
> >      'camera3_hal.cpp',
> > -    'camera_hal_manager.cpp',
> >      'camera_device.cpp',
> >      'camera_hal_config.cpp',
> > +    'camera_hal_manager.cpp',
> >      'camera_metadata.cpp',
> >      'camera_ops.cpp',
> >      'camera_stream.cpp',

-- 
Regards,

Laurent Pinchart