[libcamera-devel] [PATCH v2 0/2] Raspberry Pi: Metadata parsing improvements (II)

[Naushir Patuck]

Hi,

Here is version 2 of this series.  The following changes have been introduced
over v1:

- Rework patch 1/2 to use a unique_ptr to store the parser object in the
CamHelper class.
- Switch to using std::initialiser_list in the constructor of MdParserSmia.
- All suggestions from Laurent's feedback have been addressed in patch 2/2.

The constructor for the unique_ptr<MdParserSmia> in patch 2/2 looks a bit
awkward now since I have to explicitly write std::initialiser_list within
std::make_unique, but I cannot see nice way around this.

I have removed all previous tags from 1/2, as this is a completely different
approach to the previous revision.

Thanks,
Naush

Naushir Patuck (2):
  ipa: raspberrypi: Use a unique_ptr for the metadata parser
  ipa: raspberrypi: Generalise the SMIA metadata parser

 src/ipa/raspberrypi/cam_helper.cpp        |  38 ++++---
 src/ipa/raspberrypi/cam_helper.hpp        |   7 +-
 src/ipa/raspberrypi/cam_helper_imx219.cpp | 117 ++++----------------
 src/ipa/raspberrypi/cam_helper_imx290.cpp |   2 +-
 src/ipa/raspberrypi/cam_helper_imx477.cpp | 123 ++++------------------
 src/ipa/raspberrypi/cam_helper_ov5647.cpp |   2 +-
 src/ipa/raspberrypi/md_parser.hpp         |  42 +++++---
 src/ipa/raspberrypi/md_parser_smia.cpp    |  66 ++++++++++--
 8 files changed, 155 insertions(+), 242 deletions(-)

-- 
2.25.1