[libcamera-devel] [PATCH] libcamera: pipeline: simple: converter: Improve error message

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Jun 27 21:00:09 CEST 2021


When the configuration of the converter fails due to format mismatch,
the error messages only indicates that a failure occurred. Improve it to
ease debugging by printing the requested and obtained formats.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/libcamera/pipeline/simple/converter.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp
index 9af1096be834..3baf78f9364c 100644
--- a/src/libcamera/pipeline/simple/converter.cpp
+++ b/src/libcamera/pipeline/simple/converter.cpp
@@ -64,7 +64,9 @@ int SimpleConverter::Stream::configure(const StreamConfiguration &inputCfg,
 	if (format.fourcc != videoFormat || format.size != inputCfg.size ||
 	    format.planes[0].bpl != inputCfg.stride) {
 		LOG(SimplePipeline, Error)
-			<< "Input format not supported";
+			<< "Input format not supported (requested "
+			<< inputCfg.size.toString() << "-" << videoFormat.toString()
+			<< ", got " << format.toString() << ")";
 		return -EINVAL;
 	}
 
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list