[libcamera-devel] [RFC PATCH 11/14] FULL: pipeline: ipu3: Set AeEnable ControlInfo

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

The subject shouldn't start with "FULL: ". Same for patch 10/14 and
12/14 to 14/14.

On Fri, Jun 18, 2021 at 07:33:48PM +0900, Paul Elder wrote:
> Set the AeEnable ControlInfo in IPU3, to satisfy CTS FULL
> requirements.

It's not just to satisfy the CTS FULL requirements, we want the IPU3 IPA
implementations to support enabling and disabling AE. I'd write the
commit message based on that. Same comment for the other patches in the
series.

> Bug: https://bugs.libcamera.org/show_bug.cgi?id=42
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 1899f389..a9faa9e3 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -48,6 +48,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;
>  static constexpr Size IPU3ViewfinderSize(1280, 720);
>  
>  static const ControlInfoMap::Map IPU3Controls = {
> +	{ &controls::AeEnable, ControlInfo(false, true) },
>  	{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },
>  	{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },
>  };

-- 
Regards,

Laurent Pinchart