[libcamera-devel] [RFC PATCH 12/14] FULL: pipeline: ipu3: Set AeLock ControlInfo

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jun 28 03:55:58 CEST 2021


Hi Paul,

Thank you for the patch.

On Fri, Jun 18, 2021 at 07:33:49PM +0900, Paul Elder wrote:
> Set the AeLock ControlInfo in IPU3, to satisfy CTS FULL
> requirements.
> 
> Bug: https://bugs.libcamera.org/show_bug.cgi?id=43
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index a9faa9e3..f315a411 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -49,6 +49,7 @@ static constexpr Size IPU3ViewfinderSize(1280, 720);
>  
>  static const ControlInfoMap::Map IPU3Controls = {
>  	{ &controls::AeEnable, ControlInfo(false, true) },
> +	{ &controls::AeLock, ControlInfo(false, true) },

Assuming the discussions on 03/14 conclude it's the way to go, and with
the comments on 11/14 addressed,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  	{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },
>  	{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },
>  };

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list