[libcamera-devel] [PATCH v3 2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Jun 28 08:10:57 CEST 2021
Hi David,
Thank you for the patch.
On Fri, Jun 18, 2021 at 11:04:29PM +0100, David Plowman wrote:
> Warnings about the lack of AWB status results are demoted to being
> just "Debug". With monochrome sensors becoming more common this would
> otherwise overwhelm the console output, and in practice nothing is
> really lost as it is normally very evident if AWB is failing to run.
>
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> Reviewed-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-
> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp
> index 55e80ac7..2c95f287 100644
> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp
> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp
> @@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata)
> awb_.gain_g = 1.0;
> awb_.gain_b = 1.0;
> if (image_metadata->Get("awb.status", awb_) != 0)
> - LOG(RPiAgc, Warning) << "Agc: no AWB status found";
> + LOG(RPiAgc, Debug) << "Agc: no AWB status found";
> }
>
> static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb,
> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp
> index b0d24aa2..ef99c1b0 100644
> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp
> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp
> @@ -267,8 +267,8 @@ double get_ct(Metadata *metadata, double default_ct)
> AwbStatus awb_status;
> awb_status.temperature_K = default_ct; // in case nothing found
> if (metadata->Get("awb.status", awb_status) != 0)
> - LOG(RPiAlsc, Warning) << "no AWB results found, using "
> - << awb_status.temperature_K;
> + LOG(RPiAlsc, Debug) << "no AWB results found, using "
> + << awb_status.temperature_K;
> else
> LOG(RPiAlsc, Debug) << "AWB results found, using "
> << awb_status.temperature_K;
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list