[libcamera-devel] [PATCH v5 5/9] qcam: viewfinder_gl: fix wrong comment in bayer_8.frag

[paul.elder at ideasonboard.com]

Hi Andrey,

On Tue, Jun 22, 2021 at 04:46:48PM +0300, Andrey Konovalov wrote:
> Fetching into value[2] corresponds to E0, and fetching into value[3] - to
> F0. The fetch()-es themselves are correct, but the comments were not.
> 
> Signed-off-by: Andrey Konovalov <andrey.konovalov at linaro.org>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  src/qcam/assets/shader/bayer_8.frag | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag
> index 707e76ed..74a6322f 100644
> --- a/src/qcam/assets/shader/bayer_8.frag
> +++ b/src/qcam/assets/shader/bayer_8.frag
> @@ -68,8 +68,8 @@ void main(void) {
>      vec4 value = vec4(
>          fetch(center.x, yCoord[0]),   // ( 0,-2)
>          fetch(center.x, yCoord[1]),   // ( 0,-1)
> -        fetch(xCoord[0], center.y),   // (-1, 0)
> -        fetch(xCoord[1], center.y));  // (-2, 0)
> +        fetch(xCoord[0], center.y),   // (-2, 0)
> +        fetch(xCoord[1], center.y));  // (-1, 0)
>  
>      vec4 temp = vec4(
>          fetch(center.x, yCoord[3]),   // ( 0, 2)
> -- 
> 2.25.1
>