[libcamera-devel] [PATCH] libcamera: Move uneeded comment from pipeline handler

[paul.elder at ideasonboard.com]

Hi Jean-Michel,

On Mon, Jun 28, 2021 at 10:04:13PM +0200, Jean-Michel Hautbois wrote:
> The comment is a implementation detail and does not belong to API
> documentation. Move it inside the function.
> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> ---
>  src/libcamera/pipeline_handler.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
> index f626eddd..39eed678 100644
> --- a/src/libcamera/pipeline_handler.cpp
> +++ b/src/libcamera/pipeline_handler.cpp
> @@ -707,14 +707,14 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)
>  
>  /**
>   * \brief Retrieve the list of all pipeline handler factories
> - *
> - * The static factories map is defined inside the function to ensures it gets
> - * initialized on first use, without any dependency on link order.
> - *
>   * \return the list of pipeline handler factories
>   */
>  std::vector<PipelineHandlerFactory *> &PipelineHandlerFactory::factories()
>  {
> +	/* The static factories map is defined inside the function to ensures

s/ensures/ensure/

(Not sure if you want to change it on a simple move patch, though)

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> +	 * it gets initialized on first use, without any dependency on
> +	 * link order.
> +	 */
>  	static std::vector<PipelineHandlerFactory *> factories;
>  	return factories;
>  }
> -- 
> 2.30.2
>