[libcamera-devel] [PATCH v1 7/7] ipa: ipu3: Implement a new AGC algorithm

[Jean-Michel Hautbois]

Hi David !

On 29/06/2021 16:03, David Plowman wrote:
> HI Laurent
> 
> Yes, I think that would be fine.
> 
> Thanks
> David
> 
> On Tue, 29 Jun 2021 at 14:55, Laurent Pinchart
> <laurent.pinchart at ideasonboard.com
> <mailto:laurent.pinchart at ideasonboard.com>> wrote:
> 
>     Hi David,
> 
>     On Tue, Jun 29, 2021 at 02:22:25PM +0100, David Plowman wrote:
>     > Hi Jean-Michel
>     >
>     > Thanks for your work - very happy to see our code being useful
>     elsewhere!
>     >
>     > One minor thing - would it be ok to include a Raspberry Pi copyright
>     > alongside the IdeasonBoard one?
> 
>     I haven't looked at the code yet, but if a substantial part of it comes
>     from the RPi implementation, it should certainly mention appropriate
>     authorship and copyright information. In the kernel, we often mention it
>     as follows:
> 
>      * Based on the implementation from the Raspberry Pi IPA,
>      * Copyright (C) 2019-2021, Raspberry Pi (Trading) Ltd.
> 

I missed it, I wanted to do it !
Done on my -v2 ;-)
The implementation is a lot from RPi, but with small differences, if you
have comments, please shot :-).

>     Would that be fine with you ?
> 
>     > On Mon, 28 Jun 2021 at 21:23, Jean-Michel Hautboiswrote:
>     >
>     > > This one comes from RPi for most if it, except that we are not
>     > > exchanging any metadata between algorithms for now.
>     > > When process() is called, the current analogue gain and shutter
>     time are
>     > > calculated. The AWB stats from IPU3 are then parsed to generate new
>     > > statistics dedicated to AGC. This new grid is used to estimate the
>     > > luminance and each region is weighted. A default centered
>     metering is
>     > > used as is should be the most used one.
>     > >
>     > > After calculating weighted regions, analogue gain and shutter
>     time are
>     > > divided up and the values are then sent back to the IPAIPU3.
>     > >
>     > > Signed-off-by: Jean-Michel Hautbois
>     <jeanmichel.hautbois at ideasonboard.com
>     <mailto:jeanmichel.hautbois at ideasonboard.com>>
>     > > ---
>     > >  src/ipa/ipu3/ipu3_agc.cpp | 276
>     ++++++++++++++++++++++++--------------
>     > >  src/ipa/ipu3/ipu3_agc.h   |  23 +++-
>     > >  2 files changed, 196 insertions(+), 103 deletions(-)
> 
>     -- 
>     Regards,
> 
>     Laurent Pinchart
>