[libcamera-devel] [PATCH] libipa: Add CameraSensorHelper for OV13858

[Kieran Bingham]

Hi JM,

On 30/06/2021 12:26, Jean-Michel Hautbois wrote:
> Hi Kieran,
> 
> Thanks for the patch.
> 
> On 30/06/2021 13:21, Kieran Bingham wrote:
>> Extend the CameraSensorHelper factory with support for an
>> OV13858 sensor as found in the Soraka Chromebook.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>> ---
>>  src/ipa/libipa/camera_sensor_helper.cpp | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
>> index 23335ed66b02..8e95b8b10102 100644
>> --- a/src/ipa/libipa/camera_sensor_helper.cpp
>> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
>> @@ -313,6 +313,20 @@ public:
>>  };
>>  REGISTER_CAMERA_SENSOR_HELPER("ov5693", CameraSensorHelperOv5693)
>>  
>> +/**
>> + * \class CameraSensorHelperOv13858
>> + * \brief Create and give helpers for the ov13858 sensor
>> + */
> 
> As proposed by Laurent, I have a patch which (among other things)
> removes the Doxygen comments for the sub-classes as it is not really
> needed: https://patchwork.libcamera.org/patch/12736/

Yes, these comments should be removed indeed.


>> +class CameraSensorHelperOv13858 : public CameraSensorHelper
>> +{
>> +public:
>> +	CameraSensorHelperOv13858()
>> +	{
>> +		analogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 256 };
> 
> This is based on minimum, maximum and step value, as you don't have the
> datasheet...
> That's something we should be thinking about: how to be sure of the
> values when we don't have the datasheet.
> A tuning code which would set the gains from min to max and compare the
> raw pixel values from one gain to another to deduce a linear (or not)
> relationship ?
> 

Definitely interesting ideas for future sensors, fortunately it sounds
like we can try to match this up against a 'close' data sheet - or try
to find out if we can confirm the correct details somehow.

--
Kieran


>> +	}
>> +};
>> +REGISTER_CAMERA_SENSOR_HELPER("ov13858", CameraSensorHelperOv13858)
>> +
>>  } /* namespace ipa */
>>  
>>  } /* namespace libcamera */
>>