[libcamera-devel] [PATCH 11/20] libcamera: pipeline: simple: Drop unused members of configuration
Kieran Bingham
kieran.bingham at ideasonboard.com
Mon Mar 1 21:12:58 CET 2021
On 31/01/2021 22:46, Laurent Pinchart wrote:
> The SimpleCameraConfiguration class has a sensorFormat_ member variable
> and a corresponding accessor that are never used. Drop them.
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> src/libcamera/pipeline/simple/simple.cpp | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 390c87ba74d8..f072e0f1fa81 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -94,8 +94,6 @@ public:
>
> Status validate() override;
>
> - const V4L2SubdeviceFormat &sensorFormat() { return sensorFormat_; }
> -
> bool needConversion() const { return needConversion_; }
>
> private:
> @@ -107,7 +105,6 @@ private:
> std::shared_ptr<Camera> camera_;
> const SimpleCameraData *data_;
>
> - V4L2SubdeviceFormat sensorFormat_;
> bool needConversion_;
> };
>
>
--
Regards
--
Kieran
More information about the libcamera-devel
mailing list