[libcamera-devel] [PATCH 09/20] libcamera: pipeline: simple: converter: Add multi-stream support

[Kieran Bingham]

On 02/03/2021 10:16, Laurent Pinchart wrote:
> Hi Kieran,
> 
> On Tue, Mar 02, 2021 at 10:12:31AM +0000, Kieran Bingham wrote:
>> On 02/03/2021 00:33, Laurent Pinchart wrote:
>>>>>> I was wondering if it would be better to reference the Stream objects
>>>>>> rather than indexes, but I can see that might become confusing with our
>>>>>> Stream *stream we already have ...
>>>>>
>>>>> I've thought about that, but it would require exposing the Stream class.
>>>>> If this was a public API I'd put more effort in the design :-)
>>>>
>>>> Heh. I think indexes are fine. Due to the masking above I guess we're
>>>> limited to 31 streams?
>>>
>>> I'd be surprised if a converter had enough bandwidth to run more than 32
>>> passes within a single frame interval :-)
>>
>> Given that there is now an internal detail here restricting the number
>> of streams, even if we're unlikely to create that many, should there be
>> an assert if someone tries to go over that amount?
>>
>> We're unlikely to get this high, so it's optional - but you never know
>> what some crazy person might do ;-)
>>
>> Perhaps it could also catch bugs if someone is adding streams without
>> care to remove or some other category of bug though.
> 
> I think I'd classify this in the category of bugs that really can never
> happen. You can quote me on this in the future ;-)

I look forward to that ;-)

-- 
Regards
--
Kieran