[libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler: Update request usage comment

[Laurent Pinchart]

Hi Kieran,

On Tue, Mar 02, 2021 at 12:41:40PM +0000, Kieran Bingham wrote:
> On 02/03/2021 12:29, Laurent Pinchart wrote:
> > On Tue, Mar 02, 2021 at 12:23:41PM +0000, Kieran Bingham wrote:
> >> When a pipeline handler completes a request, the request itself is not
> >> deleted by libcamera, and the application regains control over the
> >> object. It may choose to delete the Request, or re-use it.
> >>
> >> Clarify this in the comment by removing the declaration that the Request
> >> is deleted, but state that it is no longer managed by the pipeline
> >> handler and must not be accessed further after this function returns.
> >>
> >> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > 
> > Thank you for the patch.
> 
> You're welcome.
> 
> Anything else to add?

Maybe... After a nap :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> >> ---
> >>  src/libcamera/pipeline_handler.cpp | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
> >> index aff83af2e90e..0255d9476de0 100644
> >> --- a/src/libcamera/pipeline_handler.cpp
> >> +++ b/src/libcamera/pipeline_handler.cpp
> >> @@ -432,8 +432,8 @@ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)
> >>   * \param[in] request The request that has completed
> >>   *
> >>   * The pipeline handler shall call this method to notify the \a camera that the
> >> - * request has completed. The request is deleted and shall not be accessed once
> >> - * this method returns.
> >> + * request has completed. The request is no longer managed by the pipeline
> >> + * handler and shall not be accessed once this method returns.
> >>   *
> >>   * This method ensures that requests will be returned to the application in
> >>   * submission order, the pipeline handler may call it on any complete request

-- 
Regards,

Laurent Pinchart