[libcamera-devel] [PATCH 2/2] ipa: rkisp1: Update to kernel header changes

[Kieran Bingham]

Hi Laurent,

On 02/03/2021 20:16, Laurent Pinchart wrote:
> The rkisp1 driver has received support for newer ISP versions, which
> changes its userspace API and ABI. Adapt to the API change. This
> requires kernel v5.11 or newer, or backporting the corresponding rkisp1
> changes to older kernels.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Does this still compile with 1/2 applied? Or does it need to be squashed
down?

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/ipa/rkisp1/rkisp1.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index 67bac986aff7..f11aeb40cb05 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -216,7 +216,7 @@ void IPARkISP1::updateStatistics(unsigned int frame,
>  
>  		unsigned int value = 0;
>  		unsigned int num = 0;
> -		for (int i = 0; i < RKISP1_CIF_ISP_AE_MEAN_MAX; i++) {
> +		for (int i = 0; i < RKISP1_CIF_ISP_AE_MEAN_MAX_V10; i++) {
>  			if (ae->exp_mean[i] <= 15)
>  				continue;
>  
> 

-- 
Regards
--
Kieran