[libcamera-devel] [PATCH v2 0/3] Raspberry Pi support for new sensors

[Laurent Pinchart]

Hi David,

Thank you for the patches.

On Mon, Mar 08, 2021 at 10:39:36PM +0000, David Plowman wrote:
> Hi again everyone
> 
> Thanks to Laurent for reviewing the previous version of this
> set. Here's a version 2, taking account of his comments. The
> differences are:
> 
> 1. In the first patch some stray comment lines have been deleted.
> 
> 2. In the second patch, files have been ordered alphabetically.
> 
> 3. There's a new 3rd patch, which edits the raspberrypi.mojom file so
> that the vblank field in the SensorConfig is more accurately named
> vblankDelay.

For the whole series,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> David Plowman (3):
>   ipa: raspberrypi: Make CamHelpers return the frame delay for vblanking
>   ipa: raspberrypi: Add support for imx290/imx327 sensors
>   ipa: raspberrypi: Rename vblank field in SensorConfig to vblankDelay
> 
>  include/libcamera/ipa/raspberrypi.mojom       |   2 +-
>  src/ipa/raspberrypi/cam_helper.cpp            |   4 +-
>  src/ipa/raspberrypi/cam_helper.hpp            |  11 +-
>  src/ipa/raspberrypi/cam_helper_imx290.cpp     |  67 +++++++
>  src/ipa/raspberrypi/cam_helper_imx477.cpp     |   7 +-
>  src/ipa/raspberrypi/cam_helper_ov5647.cpp     |   7 +-
>  src/ipa/raspberrypi/data/imx290.json          | 165 ++++++++++++++++++
>  src/ipa/raspberrypi/data/meson.build          |   1 +
>  src/ipa/raspberrypi/meson.build               |   1 +
>  src/ipa/raspberrypi/raspberrypi.cpp           |   6 +-
>  .../pipeline/raspberrypi/raspberrypi.cpp      |   2 +-
>  11 files changed, 258 insertions(+), 15 deletions(-)
>  create mode 100644 src/ipa/raspberrypi/cam_helper_imx290.cpp
>  create mode 100644 src/ipa/raspberrypi/data/imx290.json

-- 
Regards,

Laurent Pinchart