[libcamera-devel] [PATCH v4 1/7] libcamera: delayed_controls: Add notion of priority write

[Kieran Bingham]

On 12/03/2021 14:04, Naushir Patuck wrote:
> Hi Kieran,
> 
> Thank you for your review feedback.
> 
>     b/src/libcamera/delayed_controls.cpp
>     >>> index ab1d40057c5f..3ed1dfebd035 100644
>     >>> --- a/src/libcamera/delayed_controls.cpp
>     >>> +++ b/src/libcamera/delayed_controls.cpp
>     >>> @@ -40,15 +40,19 @@ LOG_DEFINE_CATEGORY(DelayedControls)
>     >>>  /**
>     >>>   * \brief Construct a DelayedControls instance
>     >>>   * \param[in] device The V4L2 device the controls have to be
>     applied to
>     >>> - * \param[in] delays Map of the numerical V4L2 control ids to
>     their associated
>     >>> - * delays (in frames)
>     >>> + * \param[in] controlParams Map of the numerical V4L2 control
>     ids to their
>     >>> + * associated control parameters.
>     >>>   *
>     >>> - * Only controls specified in \a delays are handled. If it's
>     desired to mix
>     >>> - * delayed controls and controls that take effect immediately
>     the immediate
>     >>> - * controls must be listed in the \a delays map with a delay
>     value of 0.
>     >>> + * The control parameters comprise of delays (in frames) and a
>     priority write
>     >>> + * flag. If this flag is set, the relevant control is written
>     separately from,
>     >>> + * ahead of the reset of the batched controls.
>     >
>     > minor:
>     >
>     > 'and ahead of' ?
>     >
>     > could be fixed while applying if there's nothing else major:
> 
> 
>     Could you confirm if this is correct to say 'and ahead of the reset of'
>     or if it was supposed to be 'and ahead of the rest of' ...
> 
> 
> 'separately from, and ahead of the rest of` should be the correct term
> here :)
> 

Aha great.

> Happy for you to fix while applying if it is convenient for you.

Done and pushed.

--
Thanks

Kieran