[libcamera-devel] [PATCH v3 0/2] lc-compliance: Add a libcamera compliance tool

[Laurent Pinchart]

Hi Niklas,

On Wed, Mar 10, 2021 at 04:44:12PM +0100, Niklas Söderlund wrote:
> Hello,
> 
> This series adds a compliance tool to libcamera. It was developed out of
> necessity while extending and debugging the IPU3 pipeline hander. Each
> test in the tool so far have at one point triggered fatal issues in one
> pipeline or another. All known issues are however either fixed or have
> patches on ML to address them.
> 
> The tool is simple at the moment and only tests a single stream. As our
> use-cases grow more complex I hope to find time to extend the tool to
> cover more areas.

Lots of work remaining on the test front :-) This is a good starting
point. I've reviewed both patches, with lots of comments. Please address
the ones you think should be addressed immediately, and record the other
ones in \todo comments. I see no blocking issue, so I expect to ack v4.

> Niklas Söderlund (2):
>   lc-compliance: Add a libcamera compliance tool
>   lc-compliance: Add test stopping single stream with requests queued
> 
>  src/lc-compliance/main.cpp           | 139 ++++++++++++++++++
>  src/lc-compliance/meson.build        |  25 ++++
>  src/lc-compliance/results.cpp        |  75 ++++++++++
>  src/lc-compliance/results.h          |  45 ++++++
>  src/lc-compliance/simple_capture.cpp | 212 +++++++++++++++++++++++++++
>  src/lc-compliance/simple_capture.h   |  68 +++++++++
>  src/lc-compliance/single_stream.cpp  |  98 +++++++++++++
>  src/lc-compliance/tests.h            |  16 ++
>  src/meson.build                      |   2 +
>  9 files changed, 680 insertions(+)
>  create mode 100644 src/lc-compliance/main.cpp
>  create mode 100644 src/lc-compliance/meson.build
>  create mode 100644 src/lc-compliance/results.cpp
>  create mode 100644 src/lc-compliance/results.h
>  create mode 100644 src/lc-compliance/simple_capture.cpp
>  create mode 100644 src/lc-compliance/simple_capture.h
>  create mode 100644 src/lc-compliance/single_stream.cpp
>  create mode 100644 src/lc-compliance/tests.h

-- 
Regards,

Laurent Pinchart