[libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to defend the forward-declaration

[Laurent Pinchart]

Hi Paul,

On Tue, Mar 16, 2021 at 11:16:45AM +0900, paul.elder at ideasonboard.com wrote:
> On Tue, Mar 16, 2021 at 01:26:01AM +0200, Laurent Pinchart wrote:
> > On Mon, Mar 15, 2021 at 06:24:56PM +0900, Paul Elder wrote:
> > > Any struct that is defined in core.mojom with the skipHeader tag needs
> > > to be present in ipa_interface, either forward-declared or #included.
> > > Add an argument so that, in the future, people don't try to send patches
> > 
> > s/argument/command/ ?
> 
> Ah, so I typoed an entire word. What I meant was comment.

So did I... :-)

> > > removing the seemingly unused forward-declaration.
> > > 
> > > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > 
> > > ---
> > >  include/libcamera/ipa/ipa_interface.h | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
> > > index 47f81d1d..5d99e2cf 100644
> > > --- a/include/libcamera/ipa/ipa_interface.h
> > > +++ b/include/libcamera/ipa/ipa_interface.h
> > > @@ -20,6 +20,11 @@
> > >  
> > >  namespace libcamera {
> > >  
> > > +/*
> > > + * Structs that are defined in core.mojom and have the skipHeader tag must be
> > > + * forward-declared or #included here.
> > > + */
> > > +
> > >  struct CameraSensorInfo;
> > >  
> > >  class IPAInterface

-- 
Regards,

Laurent Pinchart