[libcamera-devel] [PATCH 0/7] Raspberry Pi: ipa::init() restructuring
Naushir Patuck
naush at raspberrypi.com
Wed Mar 17 11:02:04 CET 2021
Hi,
This series uses Paul's recent work and moves some initialisation code from ipa::configure()
into ipa::init(). As a consequence, the pipeline handler is now able to selectively open
the Unicam embedded data node in pipeline_handler::match(), removing some of the existing
ugliness in dealing with opening this node.
Brief patch breakdown:
Patch 1/7: Adds the sensor model string to IPASettings.
Patch 2/7: Moves the CamHelper initialise to ipa::init().
Patch 3/7: Conditionally open the embedded data node in pipeline_handler::match().
Patch 4/7: Move controller initialise to ipa::init().
Patches 5/7 - 7/7: Some tidy-ups (remove unused member variables, some renaming) after the above refactoring.
Thanks,
Naush
Naushir Patuck (7):
ipa: Add sensor model string to IPASettings
pipeline: ipa: raspberrypi: Open the CamHelper on ipa::init()
pipeline: raspberrypi: Conditionally open the embedded data node
ipa: raspberrypi: Move the controller initialise to ipa::init()
ipa: raspberrypi: Remove unused member variables
ipa: raspberrypi: Rationalise parameters to ipa::start()
ipa: raspberrypi: Rationalise parameters to ipa::configure()
include/libcamera/ipa/core.mojom | 8 ++
include/libcamera/ipa/raspberrypi.mojom | 27 ++--
src/ipa/raspberrypi/raspberrypi.cpp | 110 +++++++--------
.../pipeline/raspberrypi/raspberrypi.cpp | 128 ++++++++----------
src/libcamera/pipeline/vimc/vimc.cpp | 2 +-
test/ipa/ipa_interface_test.cpp | 2 +-
6 files changed, 119 insertions(+), 158 deletions(-)
--
2.25.1
More information about the libcamera-devel
mailing list