[libcamera-devel] [PATCH 5/7] ipa: raspberrypi: Remove unused member variables

Naushir Patuck naush at raspberrypi.com
Wed Mar 17 11:02:09 CET 2021


With the recent refactoring of code from ipa::configure() to ipa::init()
some member variable are now unused, so remove them.

Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
---
 src/ipa/raspberrypi/raspberrypi.cpp | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
index e2db0716b84b..2ca64bcdb80a 100644
--- a/src/ipa/raspberrypi/raspberrypi.cpp
+++ b/src/ipa/raspberrypi/raspberrypi.cpp
@@ -67,8 +67,7 @@ class IPARPi : public ipa::RPi::IPARPiInterface
 {
 public:
 	IPARPi()
-		: lastMode_({}), controller_(), controllerInit_(false),
-		  frameCount_(0), checkCount_(0), mistrustCount_(0),
+		: controller_(), frameCount_(0), checkCount_(0), mistrustCount_(0),
 		  lsTable_(nullptr), firstStart_(true)
 	{
 	}
@@ -129,12 +128,10 @@ private:
 
 	/* Camera sensor params. */
 	CameraMode mode_;
-	CameraMode lastMode_;
 
 	/* Raspberry Pi controller specific defines. */
 	std::unique_ptr<RPiController::CamHelper> helper_;
 	RPiController::Controller controller_;
-	bool controllerInit_;
 	RPiController::Metadata rpiMetadata_;
 
 	/*
@@ -387,8 +384,6 @@ int IPARPi::configure(const CameraSensorInfo &sensorInfo,
 		result->controls = std::move(ctrls);
 	}
 
-	lastMode_ = mode_;
-
 	return 0;
 }
 
-- 
2.25.1



More information about the libcamera-devel mailing list