[libcamera-devel] [PATCH 5/5] Documentation: guides: pipeline-handler: Fix capture flag usage

Sebastian Fricke sebastian.fricke at posteo.net
Thu Mar 18 06:21:20 CET 2021


Hey Nícolas,

Thank you for the patch.

Reviewed-by: Sebastian Fricke <sebastian.fricke at posteo.net>

On 17.03.2021 16:28, Nícolas F. R. A. Prado wrote:
>The number of frames passed to the -C flag of cam should come right
>after it, without a space, otherwise the value is discarded.
>The log below already showed the correct usage, but the command in the
>code-block was wrong, so fix it.
>
>Signed-off-by: Nícolas F. R. A. Prado <nfraprado at collabora.com>
>---
> Documentation/guides/pipeline-handler.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst
>index bcce86793ccd..8ef83fea9837 100644
>--- a/Documentation/guides/pipeline-handler.rst
>+++ b/Documentation/guides/pipeline-handler.rst
>@@ -1433,7 +1433,7 @@ capture through the pipeline through both of the cam and qcam utilities.
> .. code-block:: shell
>
>    ninja -C build
>-   ./build/src/cam/cam -c vivid -C 5
>+   ./build/src/cam/cam -c vivid -C5

I think this could be even more descriptive by writing:
```
./build/src/cam/cam --camera=vivid --capture=5
```
But that is probably just my own preference.

>
> To test that the pipeline handler can detect a device, and capture input.
>
>-- 
>2.30.2
>
>_______________________________________________
>libcamera-devel mailing list
>libcamera-devel at lists.libcamera.org
>https://lists.libcamera.org/listinfo/libcamera-devel


More information about the libcamera-devel mailing list